Skip to content

Conversation

@artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Nov 13, 2024

PMM-7

  • Links to related pull requests (optional).

Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@artemgavrilov artemgavrilov requested a review from a team as a code owner November 13, 2024 15:56
@artemgavrilov artemgavrilov requested review from BupycHuk and JiriCtvrtka and removed request for a team November 13, 2024 15:56
@artemgavrilov artemgavrilov enabled auto-merge (squash) November 13, 2024 15:56
@artemgavrilov artemgavrilov merged commit a9fe1e0 into main Nov 14, 2024
14 checks passed
@artemgavrilov artemgavrilov deleted the forum-badge branch November 14, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants